search

roboticslab-uc3m / teo-grasp

App for grasping objects with Teo using OpenRave to simulate it
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Mismatch in install of share/models #2

Closed jgvictores closed 6 years ago

jgvictores commented 6 years ago

Mismatch in install of share/models:

rsantos88 commented 6 years ago

solved it (b8bd40bf0442faaaf454882b5c12f4305f88efbf) Thanks @jgvictores

jgvictores commented 6 years ago

b8bd40bf0442faaaf454882b5c12f4305f88efbf was pretty hard-coded... Good example:

Note the unfortunate mix of kebab-case and SCREAMING_SNAKE_CASE, documented as best as possible as stated https://github.com/roboticslab-uc3m/best-practices/issues/5#issuecomment-345614754

rsantos88 commented 6 years ago

b8bd40b was pretty hard-coded...

solved it (492dd2dcb74605a39d9ee37b859075e83023da37)

jgvictores commented 6 years ago

That looks much better!!!

Thanks!

jgvictores commented 6 years ago

Ok, sorry to bug on this issue, there are now duplicates:

  1. https://github.com/roboticslab-uc3m/teo-grasp/blob/492dd2dcb74605a39d9ee37b859075e83023da37/share/CMakeLists.txt#L8
  2. https://github.com/roboticslab-uc3m/teo-grasp/blob/492dd2dcb74605a39d9ee37b859075e83023da37/share/models/CMakeLists.txt#L9

I'd remove the second one, which should not be required.

rsantos88 commented 6 years ago

@jgvictores don't worry, it's ok. I've removed the second one :+1: (c3f4af41e143b0d4fdf0fdad42e40bae86c67b63) If you see something wrong, tell me.

jgvictores commented 6 years ago

Commited a26a55e898ee23ab2f492d481ed96427784a6626 :-)

jgvictores commented 6 years ago

PS: Much more info on this here: http://www.yarp.it/yarp_external_build.html

jgvictores commented 6 years ago

Also commited: 1aa055c0e2dd6de11df1c2e810c6d7b52c83274a