search

roboticslab-uc3m / teo-openrave-models

TEO OpenRAVE models.
http://roboticslab.uc3m.es/roboticslab/robot/teo-humanoid
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Review "TCP" links in TEO model #38

Open jgvictores opened 5 years ago

jgvictores commented 5 years ago

At https://github.com/roboticslab-uc3m/teo-openrave-models/commit/320b0f4fbcb56cebd6a7eea2f31d29abfae76829 for https://github.com/roboticslab-uc3m/teo-openrave-models/pull/36 i discovered some redundant transformations that may have meant sense in the past but now may not.

Here's an example (and there are 2 or 4 in total), compare:

It can be seen that they are explicitly designed to compensate each other. Must rethink. Also related to https://github.com/roboticslab-uc3m/openrave-yarp-plugins

rsantos88 commented 5 years ago

It can be seen that they are explicitly designed to compensate each other.

Yes, that seems. I will correct it when the issue https://github.com/roboticslab-uc3m/teo-openrave-models/issues/37 are finished

jgvictores commented 5 years ago

Marking as blocked, as this still needs some thought and is related to https://github.com/roboticslab-uc3m/openrave-yarp-plugins, specifically libraries/YarpPlugins/YarpOpenraveControlboard.

jgvictores commented 4 years ago

Some history: