Jr3 improvement: new calibrateSensor and calibrateChannel functions

roboticslab-uc3m / yarp-devices

A place for YARP devices

https://robots.uc3m.es/yarp-devices/

9 stars 7 forks source link

Jr3 improvement: new calibrateSensor and calibrateChannel functions #199

Closed rsantos88 closed 5 years ago

rsantos88 commented 5 years ago

implemented calibrateSensor and calibrateChannel functions
created new example to test the new calibrating functions

coveralls commented 5 years ago

Coverage remained the same at ?% when pulling 82f61515b2ca0ca1d7c3a2c0d0a1d994fa743f65 on jr3-improvement into 3cfd0b41f4c04c8074f886a4cdf93a01b3656a8f on develop.

jgvictores commented 5 years ago

The example is in fact local, so:

exampleRemoteJr3-2 -> exampleJr3 (following the naming conventions of the other examples, that put nothing if local)
L29 and L30 can dissapear: https://github.com/roboticslab-uc3m/yarp-devices/blob/b5c6b3db6244f305f0098a7f0ecef46675ead1f4/examples/cpp/exampleRemoteJr3-2/exampleRemoteJr3-2.cpp#L29-L30

jgvictores commented 5 years ago

@rsantos88 Is this WIP or ready for review/merge?

rsantos88 commented 5 years ago

Yes! I've fixed the errors of the notes. Review it and if you don't see anything stranger, merge it :)

PeterBowman commented 5 years ago

Could you remove the autogenerated Qt file from the commit history (git amend + interactive rebase)?

rsantos88 commented 5 years ago

Ok @PeterBowman. I've removed the file from the git repository history and from commit history using git rebase -i. Please, review it