roboticslab-uc3m / yarp-devices

A place for YARP devices
https://robots.uc3m.es/yarp-devices/
9 stars 7 forks source link

Major CAN rework #229

Closed PeterBowman closed 4 years ago

PeterBowman commented 5 years ago

This PR tracks several [CAN-TEO] issues, detailed as follows:

TODOs:

PeterBowman commented 4 years ago

Useful info regarding move semantics (includes perfec#- - t forwarding):

More on passing function objects by value/lvalue/rvalue as function arguments:

PeterBowman commented 4 years ago

First console output: locomotion-20191213.txt.

PeterBowman commented 4 years ago

This PR has long exceeded the limit of 250 browseable commits, and helpful comments are buried deep among commit titles (https://github.com/roboticslab-uc3m/yarp-devices/pull/229#issuecomment-550268884), so I'm going to close it, at last. Also, my initial assigment was due by the end of 2019 (kinda), and I need other people to test this code extensively. Both facts convinced me to merge apocanlypse now and start a new branch with moar follow-ups at some point afterwards (and another catchy name, too). Bonus TEO feature if you can find the easter egg.

This PR was developed along with new .ini files on robot-specific repositories: https://github.com/roboticslab-uc3m/teo-configuration-files/commit/b17cea86b4ba1901de1e2fe8ccad96dc0186dac0, https://github.com/roboticslab-uc3m/asibot-configuration-files/commit/e02bfc67c363cf0353ad78921904ed50f59b1ac5.

Disclaimers:

  1. Left arm CAN bus is sometimes down, I suspect a wiring issue. (cc @rsantos88)
  2. Onboard TEO PCs now run the new code.
  3. Mind https://github.com/roboticslab-uc3m/yarp-devices/issues/170.

Happy 2020.

PS "apocanlypse now" was totally unintended.

PS2 just noticed (Feb '20) the alternative spelling "Majorcan rework" (as in the Majorca island). Sorry, it's stronger than me.