Closed PeterBowman closed 4 years ago
Useful info regarding move semantics (includes perfec#- - t forwarding):
std::move
)More on passing function objects by value/lvalue/rvalue as function arguments:
First console output: locomotion-20191213.txt.
This PR has long exceeded the limit of 250 browseable commits, and helpful comments are buried deep among commit titles (https://github.com/roboticslab-uc3m/yarp-devices/pull/229#issuecomment-550268884), so I'm going to close it, at last. Also, my initial assigment was due by the end of 2019 (kinda), and I need other people to test this code extensively. Both facts convinced me to merge apocanlypse now and start a new branch with moar follow-ups at some point afterwards (and another catchy name, too). Bonus TEO feature if you can find the easter egg.
This PR was developed along with new .ini files on robot-specific repositories: https://github.com/roboticslab-uc3m/teo-configuration-files/commit/b17cea86b4ba1901de1e2fe8ccad96dc0186dac0, https://github.com/roboticslab-uc3m/asibot-configuration-files/commit/e02bfc67c363cf0353ad78921904ed50f59b1ac5.
Disclaimers:
Happy 2020.
PS "apocanlypse now" was totally unintended.
PS2 just noticed (Feb '20) the alternative spelling "Majorcan rework" (as in the Majorca island). Sorry, it's stronger than me.
This PR tracks several [CAN-TEO] issues, detailed as follows:
pulsesPerSample
Technosoft device configuration parameter.CanBusControlboard::open
needed some love; now, most stuff was moved to the respective subdevice initialization methods or other, more convenient places.yarp::dev::IMotor
,yarp::dev::IMotorEncoders
andyarp::dev::IAxisInfo
in TechnosoftIpos.TODOs:
std::atomic
in newStateVariables
class.std::bind
?).DriveStatusMachine
methods instead ofCanOpen::rpdo1
?StateVariables::reportBitToggle
(YARP logger?)checkMotionDone
failures).