search

roboticslab-uc3m / yarp-devices

A place for YARP devices
https://robots.uc3m.es/yarp-devices/
9 stars 7 forks source link

Finalize CAN rework #243

Closed PeterBowman closed 4 years ago

PeterBowman commented 4 years ago

Follow-up of https://github.com/roboticslab-uc3m/yarp-devices/pull/229 and a final (?) take on the [CAN-TEO] project.

Closes https://github.com/roboticslab-uc3m/yarp-devices/issues/160, closes https://github.com/roboticslab-uc3m/yarp-devices/issues/170, closes https://github.com/roboticslab-uc3m/yarp-devices/issues/221, closes https://github.com/roboticslab-uc3m/yarp-devices/issues/222, closes https://github.com/roboticslab-uc3m/yarp-devices/issues/223, closes https://github.com/roboticslab-uc3m/yarp-devices/issues/231, closes https://github.com/roboticslab-uc3m/yarp-devices/issues/232, closes https://github.com/roboticslab-uc3m/yarp-devices/issues/242.

The following substasks have been considered but finally discarded or deferred until a later moment:

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.05%) to 99.218% when pulling ef71fc039e1aa143b2a05a844d254511f40c2790 on road-to-canhalla into 71c5524a63c64af63c19f9e332e7808c3c1d1c15 on develop.

PeterBowman commented 4 years ago

Now it is good to go. Optional side-quests have been added in the description.

Keep in mind commit https://github.com/roboticslab-uc3m/yarp-devices/pull/243/commits/ef71fc039e1aa143b2a05a844d254511f40c2790 concerning the internal template implementation check (ok boolean) prior to returning from the following functions:

https://github.com/roboticslab-uc3m/yarp-devices/blob/ef71fc039e1aa143b2a05a844d254511f40c2790/libraries/YarpDeviceMapperLib/DeviceMapper.hpp#L175-L190

https://github.com/roboticslab-uc3m/yarp-devices/blob/ef71fc039e1aa143b2a05a844d254511f40c2790/libraries/YarpDeviceMapperLib/DeviceMapper.hpp#L196-L212