search

roboticslab-uc3m / yarp-devices

A place for YARP devices
https://robots.uc3m.es/yarp-devices/
9 stars 7 forks source link

Compare grabberControls2Gui vs iCub frameGrabberGui2-qt and focusTool #244

Open jgvictores opened 4 years ago

jgvictores commented 4 years ago

Compare our grabberControls2Gui (perma) vs iCub frameGrabberGui2 and focusTool. Discovered via https://github.com/robotology/icub-main/issues/416.

jgvictores commented 4 years ago

focusTool

Made quite a few hacks to make it compile, modified main() to config.put("device","remote_grabber");. Segfaults on connect, do not understand intention. Resolution: discarded a.k.a. nevermind. : )

frameGrabberGui2

Does seem interesting. I had an older version and was able to use the slider to command a gain modification of YarpOpenraveGrabber. Now it reports Remote camera device has no IFrameGrabberControl2 interface. Probably unrelated is the fact that https://github.com/robotology/yarp/releases/tag/v3.0.0 states "deprecate IFrameGrabberControl2 in favour of IFrameGrabberControl": it's probably just many missing implementations on the YarpOpenraveGrabbe side at time of writing.

(Edit: frameGrabberGui2 instead of frameGrabberGui2-qt)

jgvictores commented 4 years ago

Remote camera device has no IFrameGrabberControl2 interface

Seems fixable: https://github.com/robotology/icub-main/blob/6c61f6c507a711962a4f4a961753732ca6e238cd/src/tools/frameGrabberGui2-qt/mainwindow.cpp#L362-L373

jgvictores commented 4 years ago

Remote camera device has no IFrameGrabberControl2 interface

Fixed via https://github.com/roboticslab-uc3m/openrave-yarp-plugins/commit/72dab2af8da703bfd375b1c748deb561de67753f for simulated camera. Still back to situation where only GAIN is controllable.

PeterBowman commented 4 years ago

frameGrabberGui2

Note it has been placed on the Maybe list for inclusion in a future YARP 3.5.0 release (ref).