roboticslab-uc3m / yarp-devices

A place for YARP devices
https://robots.uc3m.es/yarp-devices/
9 stars 7 forks source link

Halt bit not reset on pos->vel mode change #256

Closed PeterBowman closed 2 years ago

PeterBowman commented 3 years ago

Steps:

Implementation:

https://github.com/roboticslab-uc3m/yarp-devices/blob/31a33617549dcc5f2715b63876e95a3076bf87a1/libraries/YarpPlugins/TechnosoftIpos/IPositionControlRawImpl.cpp#L15-L25

Debug output tells absolutely nothing on return, so I presume this is caused by the "check halt bit" condition. See also:

https://github.com/roboticslab-uc3m/yarp-devices/blob/00187c32798536c0ea0ae2249b151c170b8c5493/libraries/YarpPlugins/TechnosoftIpos/IControlModeRawImpl.cpp#L97-L101

And:

https://github.com/roboticslab-uc3m/yarp-devices/blob/00187c32798536c0ea0ae2249b151c170b8c5493/libraries/YarpPlugins/TechnosoftIpos/TechnosoftIpos.cpp#L279-L285

PeterBowman commented 3 years ago

I'm introducing halt commands in legacy IP mode, so perhaps it should be reviewed once again in a broader context: https://github.com/roboticslab-uc3m/yarp-devices/commit/99b7f4119ff91fddcb91b1bf6d0194cda0f037cd.

PeterBowman commented 2 years ago

I don't understand this issue anymore, one joint should not affect others regarding their internal state. I tried to reproduced the steps today and failed, everything works nicely. For now, I'm going to close this as invalid.