robotictang / razor_imu_9dof

This is a ROS driver and firmware to connect to Razor IMU 9DOF (Degree of Freedom) board. This board consists of 3 sensor: magnetic, gyro and accelerator sensor.
20 stars 138 forks source link

Queries #4

Open QuadRobo opened 10 years ago

QuadRobo commented 10 years ago

I have a few queries about the above package summary which you placed in ROS

1) Would you catkinize the package in the future? I am using ROS hydro. 2) Would your code work with this product: https://www.sparkfun.com/product= s/10724 It does not have an on-board ATmega328 compared to https://www.sparkfun.com= /products/10736 which is what your code is based on.

robotictang commented 10 years ago

Question 1: I am not sure how to catkinize the package. Can you show me a link to do this?

Question 2: Currently I am very busy on research. Can you port the compatibility to other hardware version? Or you can fork my package and create your own version. This software is open source for the reason that you can make modification to it. I also know the hardware version keep changing.

QuadRobo commented 10 years ago

Q1. http://wiki.ros.org/catkin/migrating_from_rosbuild for catkin tutorial.

Q2. I am trying to understand your code with much difficulty as I do not have programming background. Therefore I do not know where to start from.

KristofRobot commented 10 years ago

Note that I catkinized this in my fork - see https://github.com/KristofRobot/razor_imu_9dof .

I launched a pull request to merge this some time ago (see #3), but retracted that after there was no response for several months.

Let me know if still interested. Alternatively, feel free to cherrypick from my fork what you find useful (e.g. only the catkinization).

QuadRobo commented 10 years ago

I have just noticed that in your readme file, it says to download from https://github.com/robotictang/razor_imu_9dof.git. But the website uses manifest instead of package which catkin uses. It should be downloaded from https://github.com/KristofRobot/razor_imu_9dof for the catkin version.

KristofRobot commented 10 years ago

@QuadRobo - Thats correct, that was because I was trying to merge things with master at the time. Just keeping it like that for now, @robotictang might want to merge/cherrypick this.

PaulBouchier commented 9 years ago

Here's a thought. KristofRobot, it seems like robotictang is not willing to maintain this. If you were willing to maintain it for hydro/indigo we could update the wiki to point to your package for hydro & later, & leave groovy/fuerte pointing to robotictang's package. Or maybe robotictang would make you a committer for that repo. It seems a shame to let a useful package like this die on the vine. There are some other documentation things needing update: the location of the firmware has changed, and really the repo shouldn't contain a copy of the firmware (IMHO) - it will only get out of sync. At least not until a need is shown.

Thoughts?

KristofRobot commented 9 years ago

@PaulBouchier

I'd be fine with the solution you propose, if @robotictang indeed no longer has the cycles/willingness to support this.

@robotictang What do you think?

Kristof

robotictang commented 9 years ago

Dear all,

I am in the middle of rushing my thesis. You can do what is best for all. I already contributed my code. They are yours now.

Cheers Tang On 25 Oct 2014 16:07, "KristofRobot" notifications@github.com wrote:

@PaulBouchier https://github.com/PaulBouchier

I'd be fine with the solution you propose, if @robotictang https://github.com/robotictang indeed no longer has the cycles/willingness to support this.

@robotictang https://github.com/robotictang What do you think?

Kristof

— Reply to this email directly or view it on GitHub https://github.com/robotictang/razor_imu_9dof/issues/4#issuecomment-60475353 .

PaulBouchier commented 9 years ago

Tang, thank you for your contribution, and for being willing to let it go and let it grow under the care of others. Good luck with your thesis.

Kristof, thank you for being willing to be maintainer. Would you like me to update the wiki page to point to your github repo? That way, new issues, pulls, etc can go directly to you. I'll also add a hydro/indigo tab with catkin_make instructions.

I have to retract the proposal that the arduino firmware shouldn't be in this repo; I did not realize when I said that that Tang had modified Peter Bartz' firmware to output additional fields. Now I understand that, I will highlight on the wiki that users MUST use the modified version. In the background, we can ask Peter if he's willing to accept a pull request that would add the additional output mode to his (upstream) repo - then maybe we wouldn't need a duplicate copy, which is usually a bad idea.

Regards

Paul

KristofRobot commented 9 years ago

Would you like me to update the wiki page to point to your github repo?

Sure - will also update my README to address the comment of QuadRobo above.

Thanks for facilitating this.

Kristof