robotika / osgar

Open Source Garden (Autonomous) Robot
MIT License
13 stars 11 forks source link

Add option "repeat" for osgar.go #978

Closed m3d closed 5 months ago

m3d commented 5 months ago

python -m osgar.record config/eduro-go.json --params app.repeat=5 app.dist=-1.0 ... i.e. repeat motion backward, forward, backward, forward, backward ... Yes, the motivation is robot Pat and really small maneuver place +/-20cm so I need to repeat it enough times to give OAK-D time to start ...

tajgr commented 5 months ago

I don't know, it seems like an unsystematic change to me.

m3d commented 5 months ago

I don't know, it seems like an unsystematic change to me.

well, what would you suggest? thanks m.

tajgr commented 5 months ago

It is relevant solution for your situation. But, is the feature useful for osgar? I mean, will the feature be generally useful? not just for Pat not just now? I dont know. Maybe. If you can answer yes, feel free to merge. This is why I created separate repo for Kloubak and Spider.

m3d commented 5 months ago

It is relevant solution for your situation. But, is the feature useful for osgar? I mean, will the feature be generally useful? not just for Pat not just now? I dont know. Maybe. If you can answer yes, feel free to merge. This is why I created separate repo for Kloubak and Spider.

Well it was actually developed and tested on Eduro and simple use case is to collect more dense lidar data than from single spot. You can also see how much the odometry is drifting if you repeat it 10 times. So I see some value for all robots (or if you place it in the middle of the field how long it will take before it crashes - that is the next step I plan to do).

I am not sure if it is good idea to keep Kloubak and Spider functions outside this repo. If it is project specific (or maybe even not public) then you do not have an alternative, but if it could be used on other machines and can be open I would recommend to move it here. We may also revise this and start some osgarcore ... not sure. thanks m.