search

robotlearn / pyrobolearn

PyRoboLearn: a Python framework for Robot Learning
Apache License 2.0
402 stars 62 forks source link

Add default directories to install scripts (improvement) #15

Open markusgft opened 5 years ago

markusgft commented 5 years ago

Some install scripts ask the user for a path where to install a certain package, although it is in fact not required, as the packages are being built and subsequently globally installed to /usr/local* anway. As a user-friendly improvement, you can set a default download directory, e.g. to something like /tmp, which gets routinely deleted at startup!

Also, there is an inconsistency w.r.t. the install location in the scripts. Some scripts automatically install libraries and headers to /usr/local, otheres explicitly ask for setting the $CMAKE_PREFIX_PATH path implicitly via $LOCAL_BUILD I'd suggest to replace LOCAL_BUILD entirely by CMAKE_PREFIX_PATH since it makes it clear to the user what the variable means, and default the latter to /usr/local

lrozo commented 5 years ago

Thank you Markus for your suggestion. In fact, I also realized about this issue regarding the installation scripts when going through them. I think your suggestion makes a lot of sense!