search

robotlegs / robotlegs-framework

An ActionScript 3 application framework for Flash and Flex
https://robotlegs.tenderapp.com/
MIT License
967 stars 261 forks source link

ASC2 Compatibility #111

Closed darscan closed 11 years ago

darscan commented 11 years ago

Explore ASC2 problems.

darscan commented 11 years ago

The first release of RL2 will not bend to work around ASC2 bugs. We can address that in a patch release as it won't affect the API at all.

darscan commented 11 years ago

@creynders Do you use Flash Builder?

creynders commented 11 years ago

Yeps, I do. Is there a list of these issues? Ah I seem to remember there were troubles with the mushroom-assignments? If those have to go, I'll be a very sad Mario.

darscan commented 11 years ago

These guys ( @psykosoft ) seem to be patching their repo to work with ASC2:

https://github.com/psykosoft/robotlegs-framework/commits/master

Unfortunately, bad line-endings obscure many of their commits, so it's often hard to spot the fixes. I'm going to try checking out their repo and doing a diff locally.

darscan commented 11 years ago

Arg. I wish it was just the ||= thing, but it seems that some ridiculous changes are required.. like casting a class that implements an interface as that very interface. For example:

https://github.com/psykosoft/robotlegs-framework/commit/ebab23fed7ef59e90b8cd0e65116a5bd5327031d

creynders commented 11 years ago

F*#%, that's horrible. We'll need to maintain a separate fork if there's a lot more of those.

creynders commented 11 years ago

A lot more of those kinds of bugs I meant to say. This stuff comes close to crippling the code.

darscan commented 11 years ago

Yeh

darscan commented 11 years ago

I installed FB4.7 and started porting all the code... and I decided, "no". It's completely ridiculous to have to cast concrete classes back to the interfaces they implement. It looks and feels awful. And it's only a problem if you want to compile against the source. Linking against the SWC works fine.