search

robotlegs / robotlegs-framework

An ActionScript 3 application framework for Flash and Flex
https://robotlegs.tenderapp.com/
MIT License
966 stars 261 forks source link

MediatorMap - Switch to Command Center mapping approach #134

Closed darscan closed 11 years ago

darscan commented 11 years ago

@creynders When we rewrote the Command Center we changed how the mappings work.

It might be good to give the Mediator Map a once-over and bring it in line with the Command Center.

creynders commented 11 years ago

On my TODO-list!

darscan commented 11 years ago

Just been taking another look at it. I think it might need a bit of a rework.

creynders commented 11 years ago

Yeah, I seem to remember thinking that as well, when I last looked at it.

darscan commented 11 years ago

@creynders Do you want to tackle this, or should I?

creynders commented 11 years ago

I'm sorry, I've been really busy with work and have a hard time decontextualizing from a backbone + 7 million other JavaScribble libs app I'm developing. You can tackle it if your headspace allows.

On Monday, May 27, 2013, Shaun Smith wrote:

@creynders https://github.com/creynders Do you want to tackle this, or should I?

— Reply to this email directly or view it on GitHubhttps://github.com/robotlegs/robotlegs-framework/issues/134#issuecomment-18512741 .

Sent from Gmail Mobile

darscan commented 11 years ago

Cool, no probs

darscan commented 11 years ago

Hmm.. I tried quite hard to change the mapping approach in MediatorMap, but it's a lot more complicated than the CommandCenter. I'm not sure that this refactoring is worth it right now. Perhaps a strategy is to make sure that there is nothing too revealing in the API package, and refactor some time in the future.

darscan commented 11 years ago

Ok, I've stripped out some implementation revealing bits: https://github.com/robotlegs/robotlegs-framework/commit/5cb52485552901c655ffa4da1efa0603db19e8b4

I think this is good enough for now.