search

robotmay / photographer-io

An open source photography community. No longer in production but still open source.
MIT License
664 stars 165 forks source link

Fix layout in IE8 #16

Open robotmay opened 11 years ago

coogie commented 11 years ago

If I'm not mistaken, this is caused by Foundation 4+ being mobile-first and IE8's inability to understand media queries.

There is a nice fix that can be slipped in, provided by the lovely @zurbchris that works brilliantly with HTML5BP's html tag:

<!DOCTYPE html>
<!--[if lt IE 7]> <html class="no-js lt-ie9 lt-ie8 lt-ie7"> <![endif]-->
<!--[if IE 7]> <html class="no-js lt-ie9 lt-ie8"> <![endif]-->
<!--[if IE 8]> <html class="no-js lt-ie9"> <![endif]-->
<!--[if gt IE 8]><!--> <html class="no-js"> <!--<![endif]-->
robotmay commented 11 years ago

Thanks @coogie, I hadn't seen that before. Looks like I'll have to man up and do some testing under Windows for once :D

coogie commented 11 years ago

Actually, on further reflection, it may not be that good an idea to add layout support for IE8.

Considering its dwindling market share and the fact that IE now auto-updates from version 9 onwards, adding support for 8 would increase stylesheet size. And no testing has been done with regards to how well the site's Javascript fares in the browser. Plus, I can't imagine hits from IE8 to be all that high.

I would recommend not wasting time and energy supporting it, but instead display a notification prompting users to either upgrade their browser or install Chrome Frame.

Now, of course, if analytics prove otherwise then by all means I think this should be revisited.

robotmay commented 11 years ago

You're quite right; there really isn't much traffic from it so far this month (highest traffic has been this month). Though I suspect it could change should it become more popular. But then maybe we could deal with it then instead :D

screenshot from 2013-07-11 12 45 39