search

robotmedia / RMStore

A lightweight iOS library for In-App Purchases
Apache License 2.0
2.43k stars 450 forks source link

Added support for Carthage #157

Open mluisbrown opened 9 years ago

mluisbrown commented 9 years ago

Note:

  1. Framework target does not include any receipt verification code as it's not a good idea to include it in a dynamic framework. Should always be statically linked, as should openssl, for security reasons.
  2. If/when this PR is merged, a new tag will need to be created as Carthage by default gets the latest tagged version of a repo, which would be the one without Carthage support until there is a new tag :smile:
derpoliuk commented 8 years ago

Thank you for adding Carthage support, but I can't install it.

I added Carthfile with: github "https://github.com/mluisbrown/RMStore"

and running carthage update. I'm getting this error:

*** Skipped building RMStore due to the error:
Dependency "RMStore" has no shared framework schemes

I'm searching info how to fix it, but maybe you did it already?

mluisbrown commented 8 years ago

The problem is that Carthage will use the latest tagged version by default, which in this case won't include my changes, so you have to put:

github "https://github.com/mluisbrown/RMStore" "HEAD"

In you Cartfile to get the latest version.

derpoliuk commented 8 years ago

If/when this PR is merged, a new tag will need to be created as Carthage by default gets the latest tagged version of a repo, which would be the one without Carthage support until there is a new tag :smile:

I missed that line, thank you a lot!

mikemee commented 8 years ago

+1 for this. @hpique, can I do anything to help get this merged?

As Carthage gets more and more adoption it would be nice to get this into the main repro rather than continuing to use the HEAD from @mluisbrown (thanks!).

z4r commented 8 years ago

Any news on this?

marbetschar commented 8 years ago

Any news on this?

marbetschar commented 8 years ago

Sill can't use Carthage. @mluisbrown even your HEAD is no longer working :(

mluisbrown commented 8 years ago

What's the problem you get @marbetschar using my HEAD? It seems to be working for me...

marbetschar commented 8 years ago

@mluisbrown I've added the following to my Cartfile

github "https://github.com/mluisbrown/RMStore" "HEAD"

And when I run carthage update it outputs the following:

*** Checking out RMStore at "e0e7389df28055aa453d4303b95cd16557cb7eac"
*** xcodebuild output can be found in /var/folders/ns/0h9r9v5908x4x67v5j9wvhvw0000gn/T/carthage-xcodebuild.0XwY4J.log
*** Skipped building RMStore due to the error:
Dependency "RMStore" has no shared framework schemes

If you believe this to be an error, please file an issue with the maintainers at https://github.com/mluisbrown/RMStore/issues/new

Apart from that it would be cool to have @hpique getting the Carthage support merged :(

mluisbrown commented 8 years ago

@marbetschar ok, I synced my repo with changes from the upstream which is probably causing the problem. I have this in my Cartfile and it works fine:

github "mluisbrown/RMStore" "master"

I'm using Carthage 0.17.2

mbcharbonneau commented 7 years ago

👍 This is working well for me. I'd love to see it merged!

rbaumbach commented 7 years ago

Any update on when this will be merged?