Update defaultStore to return instancetype?

robotmedia / RMStore

A lightweight iOS library for In-App Purchases

Apache License 2.0

2.42k stars 450 forks source link

Update defaultStore to return instancetype? #215

Open chadpod opened 6 years ago

chadpod commented 6 years ago

Wondering what your thoughts are on updating

+ (RMStore *)defaultStore

to be

+ (instancetype)defaultStore

and changing sharedInstance to id?

Allows RMStore to be easily subclassed. We initially had a category on RMStore adding some of our own stuff, but I also wanted to easily store some state on it.