search

robotology-legacy / WBI-Toolbox-controllers

[WARNING]: this repository is no more mantained. Please refer to https://github.com/robotology/whole-body-controllers.
4 stars 4 forks source link

To install or not to install? #1

Closed jeljaik closed 9 years ago

jeljaik commented 9 years ago

Before definitely removing the /controllers directory from the WBI-Toolbox and using this repo instead, I was wondering:

  1. Do you agree we should install these controllers:question: Currently, if you make install this project it will copy all the controllers and simulink models to ${CODYCO_SUPERBUILD_DIR}/install/share/WBI-Toolbox-controllers/controllers
  2. What about adding it to Matlab's path when installing the WBI-Toolbox:question: cc @traversaro @DanielePucci @francesco-romano @iron76

Please vote: :+1: for yes, :-1: for no

francesco-romano commented 9 years ago

1) :-1: 2) :-1: Reasons: 1) For me controllers should be outside the codyco-superbuild and cloned manually by the user (see what we do on the new robot-pc) 2) I think by default only the libraries should be added to the path. The controllers are run either locally, or is the user the one responsible to add them. Also because of point 1 this does not apply

traversaro commented 9 years ago

Sorry, I don't have any particular opinion on the issue given my limited experience with the WBI-Toolbox-controllers.

iron76 commented 9 years ago

I agree with @francesco-romano

jeljaik commented 9 years ago

Alright then, I will prroceed to remove the controllers directory from WBI-Toolbox and highlight in the documentation that they have all been moved to this new repo.

Thanks!

On Tue Feb 03 2015 at 7:01:02 PM Francesco Nori notifications@github.com wrote:

I agree with @francesco-romano https://github.com/francesco-romano

— Reply to this email directly or view it on GitHub https://github.com/robotology-playground/WBI-Toolbox-controllers/issues/1#issuecomment-72701098 .

DanielePucci commented 9 years ago

I agree with @francesco-romano also.

traversaro commented 9 years ago

@francesco-romano what is the advantage of removing WBI-Toolbox-controllers from the codyco-superbuild ?

francesco-romano commented 9 years ago

@traversaro There is no a build associated with the repository. It is just a download. And in a lot of uses (e.g. ours) it must reside outside the superbuild folder. Anyway I've already talked to @jeljaik. We decided to integrate it (optionally) in the super build process

traversaro commented 9 years ago

@traversaro There is no a build associated with the repository. It is just a download.

Yes, and the superbuild simplifies this download step.

And in a lot of uses (e.g. ours) it must reside outside the superbuild folder.

Can you elaborate more on this?

We decided to integrate it (optionally) in the super build process

What do you think of leaving it as opt-out rather then opt-in?

jeljaik commented 9 years ago

In the end I decided to remove controllers from WBI-Toolbox and this repository is now optionally just downloaded by the superbuild. No installation of any sort is done, nor by codyco-superbuild, nor by Matlab.

Thanks for your comments.

Proceeded with commits: