Should we remove old configuration files?

robotology-legacy / WBI-Toolbox-controllers

[WARNING]: this repository is no more mantained. Please refer to https://github.com/robotology/whole-body-controllers.

4 stars 4 forks source link

Should we remove old configuration files? #62

Closed gabrielenava closed 7 years ago

gabrielenava commented 7 years ago

Inside the app/robots folder of torqueBalancing and wholeBodyImpedance controllers there are configuration files for different robots. I think some of them are quite old and probably they are not even usable anymore. In particular:

torqueBalanging

iCubDarmstadt01
iCubGenova01
iCubGenova03
iCubGenova05
iCubParis01
iCubParis01

wholeBodyImpedance

iCubDarmstadt01

should we remove them? also considering that even if deleted we can recover them if necessary looking at github history.

cc @DanielePucci

DanielePucci commented 7 years ago

Why can't we keep them?

gabrielenava commented 7 years ago

I opened them and they probably cannot work anymore because of missing variables, therefore I think that if we're going to work on one of these robots best solution will be to copy-paste configuration files from another one (probably iCubGenova04). But I agree that removing those files may be considered "premature optimization" [cit.]

traversaro commented 7 years ago

I agree to remove those files, also to clarify which platform we are supporting and which platform we are not supporting. git remembers, so even deleting it does not mean that we cannot recover them in the future.

gabrielenava commented 7 years ago

ok then! I'm going to remove these files.

gabrielenava commented 7 years ago

done with https://github.com/robotology-playground/WBI-Toolbox-controllers/commit/96fd372de2257bf603ea2a4f7dfef6581b631d85