search

robotology-legacy / codyco-modules

Whole-body Compliant Dynamical Contacts in Cognitive Humanoids
www.codyco.eu
Other
20 stars 13 forks source link

Restore compatibility with YARP 3.2.0 #280

Closed GiulioRomualdi closed 5 years ago

GiulioRomualdi commented 5 years ago

This PR updates:

The PR is already tested with the latest version of YARP robotology/yarp@8f7d73651a4b5fe5c873053f009d70dea5c4d987

See #277 for further details

cc @prashanthr05 @gabrielenava @traversaro

traversaro commented 5 years ago

As I am not really sure if this is compatible with YARP 3.0/3.1 and probably it is not really worth testing that (unless @lrapetti @kouroshD need compatibility with YARP 3.1 due to https://github.com/robotology/wearables/issues/46 / https://github.com/robotology/yarp/issues/2054 ), can you bump the minimum required YARP version to 3.2 in https://github.com/robotology/codyco-modules/blob/master/CMakeLists.txt#L34 ? Furthermore, can you also update also the other files contained in https://github.com/robotology/codyco-modules/tree/646fd2974815d26be21100a080a727786f298833/src/devices/wholeBodyDynamics/app ? Sorry for the trouble, but I know that either we updated them now, or they will never be updated. Thanks a lot.

lrapetti commented 5 years ago

unless @lrapetti @kouroshD need compatibility with YARP 3.1 due to robotology/wearables#46 / robotology/yarp#2054

The problem of not compatibility of wearable (and all the related software) with YARP 3.2 is currently affecting the compatibility with the master of many repos. This means that it is required anyhow to point some specific commit for those repos, so I think it is not that relevant for us to keep the compatibility with codyco-modules master. I think you can proceed switching to minimum required 3.2.

traversaro commented 5 years ago

Thanks @nunoguedelha . Is this ready for merging?

nunoguedelha commented 5 years ago

@traversaro I have a rebased branch but I need the rights to push to @GiulioRomualdi 's fork.

nunoguedelha commented 5 years ago

Sorry @traversaro @GiulioRomualdi actually I had the rights. Just pushed.

traversaro commented 5 years ago

Ok, now it is ready?

nunoguedelha commented 5 years ago

I've fast-forwarded the devel branch up to master.