Remove the need to use a singleton to get the ECM pointer

robotology-legacy / gym-ignition

Framework for developing OpenAI Gym robotics environments simulated with Ignition Gazebo

https://robotology.github.io/gym-ignition

GNU Lesser General Public License v3.0

231 stars 26 forks source link

Remove the need to use a singleton to get the ECM pointer #379

Closed diegoferigo closed 3 years ago

diegoferigo commented 3 years ago

Closes #378 (thanks to https://github.com/ignitionrobotics/ign-gazebo/pull/936, further details in https://github.com/ignitionrobotics/ign-gazebo/issues/248) and implements #289.

Requires https://github.com/ignitionrobotics/ign-gazebo/pull/953. Merged now in upstream, waiting forward porting to Edifice.

diegoferigo commented 3 years ago

Approving, even if I guess you want to wait for a release of the required changes to merge this.

Yes, I need https://github.com/ignitionrobotics/ign-gazebo/pull/953 to be forward ported to upstream's ign-gazebo5 (Edifice) in order to merge the PR to devel, and a new Ignition Gazebo minor release to merge devel in master.

diegoferigo commented 3 years ago

Forward porting has been done in https://github.com/ignitionrobotics/ign-gazebo/pull/968. CI is happy, at least to target devel, merging.