search

robotology-legacy / mex-wholebodymodel

Matlab MEX interface to the iWholeBodyModel interface.
11 stars 9 forks source link

Fix memory deallocation and kinematic energy conservation test #49

Closed traversaro closed 8 years ago

traversaro commented 8 years ago

This was meant to be a branch for fixing the kinetic energy conservation test, but I still failed to to this. UPDATE: Kinematic Energy test finally fixed!

However, working toward this goal I solved several bugs (namely https://github.com/robotology/mex-wholebodymodel/issues/47 and https://github.com/robotology/mex-wholebodymodel/issues/46) that drastically improve the stability of the mex-wholebodymodel.

In the process of fixing this bugs I also fixed all the -Wall warnings, at least in GCC.

As always, to get the diff without the whitespace changes (sorry for the trouble, but the repo was full of trailing whitespace) you can check https://github.com/robotology/mex-wholebodymodel/pull/49/files?w= .

The diff is quite huge, so perhaps to get an understanding on what happened in the code it is easier to inspect the individual commits.

traversaro commented 8 years ago

@naveenoid do you have any plan to have a look at this in the next 24 hours? If you don't have time I will merge, so we can continue to work on the other issues of the repo.

naveenoid commented 8 years ago

Looking at it now.

On Fri, Oct 23, 2015 at 4:43 PM, Silvio Traversaro <notifications@github.com

wrote:

@naveenoid https://github.com/naveenoid do you have any plan to have a look at this in the next 24 hours? If you don't have time I will merge, so we can continue to work on the other issues of the repo.

— Reply to this email directly or view it on GitHub https://github.com/robotology/mex-wholebodymodel/pull/49#issuecomment-150594569 .

naveenoid commented 8 years ago

Im good to merge except for weird empty function body will take a look on that today again

traversaro commented 8 years ago

Ok, let me know when we can merge.

traversaro commented 8 years ago

@gabrielenava can you check if everything still works for you?

gabrielenava commented 8 years ago

ok ! I'll do update all and than test the code before noon

DanielePucci commented 8 years ago

Corrected version: "ok ! I'll update the software and then perform the tests on the code before noon"

gabrielenava commented 8 years ago

I carried on some tests by using the torqueBalancing, and it seems that everything is working fine

naveenoid commented 8 years ago

good job. I checked too and seems fine.

On Mon, Oct 26, 2015 at 2:25 PM, gabrielenava notifications@github.com wrote:

I did the tests on balancing code and seems everything is working well

— Reply to this email directly or view it on GitHub https://github.com/robotology/mex-wholebodymodel/pull/49#issuecomment-151132223 .