Closed naveenoid closed 8 years ago
Apart for the comment that I did inline, it seems ok for me. Are the tests passing?
@naveenoid Are you sure you want to comment everything out as opposed to deleting the code? It seems to me like an old habit due to lack of code versioning tools?
@iron76 Sorry fra it was meant to be an immediate push for Silvio. I agree completely and will get all commented lines out. @traversaro tests - lets discuss quickly before I push my next commit including matlab
@traversaro ctest now works perfectly. I think the failure in my machine is related to the version of matlab Im using which explicitly needs the libstdc++ version passed to it with ld preload. It now works fine.
@naveenoid commented inline.
There are still two occurrences in the repo of wbm_setWorldLink
:
https://github.com/robotology/mex-wholebodymodel/blob/00e222b6ef681095fc7c29c94c6e493ddd24bc5b/matlab-src/mex-wholebodymodel_balancing/integrateForwardDynamics.m
and
https://github.com/robotology/mex-wholebodymodel/blob/6603ab444e828f05bcb71c0317e4421e97736ac8/matlab-src/visualizeForwardDynamics.m#L26
Can you migrate also those to the new API, perhaps checking with @gabrielenava ?
addressing it now
ping @naveenoid
push coming in in couple of hours today
@traversaro almost all issues except the cmake option -Wall added. Check and merge when you are ok with it.
Ah yes! Sorry I was wrong..correcting now asap...
Fixed..Merge when ready. Tests all passing.
:+1:
In this branch the new version without complexity of "set world link" will be tested. Matlab sources to be updated in subsequent commits.