search

robotology-legacy / mex-wholebodymodel

Matlab MEX interface to the iWholeBodyModel interface.
11 stars 9 forks source link

Fix errors and missing functions in the ChangeLog #82

Closed traversaro closed 7 years ago

traversaro commented 7 years ago

The wbm_getStates/wbm_getState mix was particularly nasty, because I searched for all the occurrences of wbm_getState to change the signature.

@gabrielenava @Ganimed please check if I got something wrong.

Ganimed commented 7 years ago

This was an typing error with copy & paste. The correct name of the function is "wbm_getState". I did not renamed the name of the wrapper-function. The function has still the old name.

Ganimed commented 7 years ago

There is still one overseen copy & paste error in the last line of the change log: _"wbm_initialise --> wbminitialise" See in: 20cff8a5940a374cfa770b1e25e4be427f735622

It should be _wbm_modelInitialise --> wbmmodelInitialize.

Ganimed commented 7 years ago

Fixed. The second release has the version number 0.1.1. But there is still mentioned version 0.2. Should I change it to 0.1.1?

traversaro commented 7 years ago

No. 0.1.1 is the tag of the commit before the merge, https://github.com/robotology/mex-wholebodymodel/blob/master/CHANGELOG.md#011 . We should tag the 0.2 release as one of recent commits in master.

Ganimed commented 7 years ago

Now I understand. The version numbers confused me a bit. But I did not changed them. I fixed only the copy & paste error.

Furthermore, last week I made some further optimizations in the C++ code. @gabrielenava: You can merge again my branch into your branch. If everything works fine, you can merge it again into the master.

P.S. These were more or less the last optimizations/changes in the subroutine. Now I cannot find anything more to optimize. But if someone finds a bug or has problems under MS-Windows or MacOS, then please let me know.