search

robotology-playground / WBI-Toolbox

Simulink Toolbox for rapid prototyping of Whole Body Robot Controllers
2 stars 2 forks source link

Fixed wbi-toolbox working with Eigen 3.0.5 #81

Closed traversaro closed 9 years ago

traversaro commented 9 years ago

cc @jeljaik @francesco-romano ugly hack, but it was to get it working. Feel free to improve.

francesco-romano commented 9 years ago

What happens if instead of 

Eigen::Ref<Eigen::VectorXd> minLimits

you use

Eigen::VectorXd &minLimits

(in the function prototype)? I'm not so happy of leaving direct access to members. Anyway @jeljaik has the last word on this.

traversaro commented 9 years ago

I think it fails because you pass to the function two Eigen::Map<Eigen::Matrix<real_T, Eigen::Dynamic, 1> > elements. Just fixed the public members problem.

francesco-romano commented 9 years ago

+1

BTW: I think it was like it is now at the beginning. Then I changed it to use Ref. I don't remember why.

traversaro commented 9 years ago

@jeljaik can we merge?

rlober commented 9 years ago

Thanks man!