search

robotology / blockfactory

A tiny framework to wrap algorithms for dataflow programming
https://robotology.github.io/blockfactory
GNU Lesser General Public License v2.1
40 stars 16 forks source link

Avoid to link mex file to too many not used libraries and fix use in MATLAB Online #62

Closed traversaro closed 3 years ago

traversaro commented 3 years ago

In particular, use the FindMatlab from CMake 3.20 plus the modification suggested in https://gitlab.kitware.com/cmake/cmake/-/issues/21912 , and then link only the actually used libraries. As soon as the discussion in upstream CMake is resolved and the issue solved in CMake, I will re-update the FindMatlab with the version that will be merge in CMake.

Fix https://github.com/robotology/robotology-superbuild/issues/653 .

traversaro commented 3 years ago

Thanks @diegoferigo , can we merge this?

diegoferigo commented 3 years ago

@traversaro yep go ahead, feel free to proceed with merging after approvals.

traversaro commented 3 years ago

@traversaro yep go ahead, feel free to proceed with merging after approvals.

Ok, we typically let the mantainer handle the merging, but given the explicit approval I will proceed (if it is ok for you, can I also proceed with a release?)

diegoferigo commented 3 years ago

@traversaro yep go ahead, feel free to proceed with merging after approvals.

Ok, we typically let the mantainer handle the merging, but given the explicit approval I will proceed (if it is ok for you, can I also proceed with a release?)

Yes, please also merge master into devel afterwards.