robotology / blockfactory

A tiny framework to wrap algorithms for dataflow programming
https://robotology.github.io/blockfactory
GNU Lesser General Public License v2.1
42 stars 16 forks source link

Clarify status of support of stateful systems #7

Open traversaro opened 5 years ago

traversaro commented 5 years ago

The blockfactory::core::Block interface of blockfactory support the following methods that seem to indicate that it supports discrete and continuous stateful systems:

however in practice it is not clear if these functions are used at all and how they are supposed to be used, as BlockInformation contain no state information at all. It may be worth to document that this methods are not used at all, and eventually remove that notice when will support stateful systems.

traversaro commented 5 years ago

Until we properly support stateful systems, it may be also reasonable to remove calls to updateDiscreteState such as https://github.com/robotology/blockfactory/blob/master/sources/Mex/src/BlockFactory.cpp#L280 .

diegoferigo commented 5 years ago

the following methods that seem to indicate that it supports discrete and continuous stateful systems

Few comments on this:

traversaro commented 5 years ago

For what concern instead discrete systems, we already have stateful blocks. For example the DiscreteFilter retains previous data in its implementation, however it does not exploit anything provided by BlockFactory and the methods you reported. There is just a note in the documentation of core::Block.

Related WB-Toolbox discussion: https://github.com/robotology/wb-toolbox/issues/165 .