robotology / cer

Contains SW specific to the R1 robots
GNU General Public License v2.0
10 stars 13 forks source link

Add support opencv4 #114

Closed Nicogene closed 4 years ago

Nicogene commented 4 years ago

It fixes #113

Please review code.

pattacini commented 4 years ago

Hold on @Nicogene Perhaps some of those modules run on r1-face where Linux distro, as well as the OpenCV version are quite outdated. Don't know whether there's already a plan to update r1-face though.

Nicogene commented 4 years ago

We discussed off-line and we decide to follow the same policy used for other icub-* repos, dropping the support for opencv 2. Also because since icub-main does not support opencv 2, then cer on r1-face it would be not compiled for icub-main "fault". The PR has been slimmed supporting only opencv 3 and 4, that they should be compatible.