search

robotology / cer

Contains SW specific to the R1 robots
GNU General Public License v2.0
10 stars 13 forks source link

Show_demo #119

Closed elandini84 closed 3 years ago

elandini84 commented 3 years ago

Added 3 xml for demo purposes. Each xml (except for base_demo.xml which is used by all the other ones) is related to a specific CER model.

elandini84 commented 3 years ago

Just a few spot comments.

As a general remark, we tend to use funny-things to store such specific contents that are very demo-oriented.

I think we could merge the PR anyway. I would only avoid adding further demo stuff in the future.

Absolutely. I wasn't aware of this fact. If anyone thinks that the PR should be closed and put somewhere else it's completely fine with me. Sorry for the mistake.

pattacini commented 3 years ago

Absolutely. I wasn't aware of this fact. If anyone thinks that the PR should be closed and put somewhere else it's completely fine with me. Sorry for the mistake.

Never mind! If you think you can get away with less, yeah that would be preferable, and very much appreciated @elandini84 👍🏻

pattacini commented 3 years ago

Hi @elandini84

Any chance you could retarget this PR onto funny-things?

elandini84 commented 3 years ago

Hi @elandini84

Any chance you could retarget this PR onto funny-things?

I needs to be slightly modified in order to be retarget onto funny-things. I'll proceed as soon as possible. Given that, I think we can close this PR, can't we?

pattacini commented 3 years ago

Given that, I think we can close this PR, can't we?

Yup, thanks heaps!