search

robotology / funny-things

A collection of "funny" yet useful behaviors for the iCub
https://robotology.github.io/funny-things
GNU General Public License v2.0
6 stars 12 forks source link

Fix iCubBlinker compilation against yarp 3.6 #23

Closed Nicogene closed 2 years ago

Nicogene commented 2 years ago

It fixes #22

traversaro commented 2 years ago

Note that we may want to mention this change in the changelog of the release, as it seems that a few other repos (see https://github.com/robotology/attention/search?q=blink, fyi @omareldardear) used the blink command that is now removed.

traversaro commented 2 years ago

Other code affected:

Nicogene commented 2 years ago 
https://github.com/icub-tech-iit/appsAway/blob/d407f3405f5743bd1c0a7c54338c9bbf0cf89775/demos/funnyThingsApp/script/funnythings_template.sh#L64 fyi @vtikha

This should be addressed by the changes in this PR.

Do you mean we should add a changelog in this repo?

traversaro commented 2 years ago 
https://github.com/icub-tech-iit/appsAway/blob/d407f3405f5743bd1c0a7c54338c9bbf0cf89775/demos/funnyThingsApp/script/funnythings_template.sh#L64 fyi @vtikha

This should be addressed by the changes in this PR.

Ah sorry, I did not see this.

Do you mean we should add a changelog in this repo?

No, even just mentioning it in the releases notes it is ok for me.