search

robotology / gazebo-fmi

FMI import plugins for the Gazebo Simulator.
GNU Lesser General Public License v3.0
23 stars 5 forks source link

First version of the Single Body Fluid Dynamics FMI plugin #41

Closed traversaro closed 5 years ago

traversaro commented 5 years ago

This plugin is useful for co-simulating the interaction between a (single) link in the model and a surrounding medium. It can be used for simple lumped parameters models, or eventually also for co-simulation with CFD solvers, but the latter case has not been tested and it would probably be extremely slow.

For more info, see the docs:

The PR https://github.com/robotology/gazebo-fmi/pull/40 needs to be merged before merging this one, so the actual difference of this PR is actually in the commit https://github.com/robotology/gazebo-fmi/pull/41/commits/febb3c42b38b8bbd7c734d0af13286df69a98729 .

traversaro commented 5 years ago

No problem @gabrielenava , @prashanthr05 already reviewed and I still need to address it. : )

traversaro commented 5 years ago

I should have addressed all the reviews.

traversaro commented 5 years ago

@prashanthr05 Can you check if I address your reviews? Thanks!

prashanthr05 commented 5 years ago

@traversaro I am sorry for the delay. I was thinking I had approved this request.

However, looks like Travis is failing for gazebo-7 ? Are we supporting Gazebo 7?

traversaro commented 5 years ago

However, looks like Travis is failing for gazebo-7 ? Are we supporting Gazebo 7?

Discussion on this in https://github.com/robotology/gazebo-fmi/pull/44 .

traversaro commented 5 years ago

Rebased on the top of https://github.com/robotology/gazebo-fmi/pull/29, this means that this needs to be merged after https://github.com/robotology/gazebo-fmi/pull/29 .