search

robotology / gym-ignition-models

Collection of robot models compatible with gym-ignition
https://github.com/robotology/gym-ignition
GNU Lesser General Public License v3.0
24 stars 7 forks source link

Add iCubGazeboV2_5 model #1

Closed diegoferigo closed 4 years ago

diegoferigo commented 4 years ago

The iCub model has been taken from iCubGazeboV2_5/model.urdf and adapted to work in Ignition Gazebo.

iCubGazeboV2_5

diegoferigo commented 4 years ago

It speeds up development though :) I didn't consider comparisons, you're right. It's too late now to roll back, a rebase would not work in this case.

traversaro commented 4 years ago

It speeds up development though :)

Just to understand, why four spaces indent speeds up the development over two spaces indent? Note that those files were already indented programmatically using the pretty_print option of lxml.

diegoferigo commented 4 years ago

It's not the indentation that speeds up the development. Simply, when I save in my setup all files get reformatted, and it happened that I had the 4 spaces enabled by default.

diegoferigo commented 4 years ago

As a workaround, I can format back the file to 2 spaces. One extra commit would not harm :)

traversaro commented 4 years ago

As a workaround, I can format back the file to 2 spaces. One extra commit would not harm :)

As you prefer, you can even just re-format back when we will need comparisons.