robotology / gz-sim-yarp-plugins

YARP plugins for Modern Gazebo (gz-sim).
BSD 3-Clause "New" or "Revised" License
8 stars 0 forks source link

Fix controlboard bug on resetPositionsAndTrajectoryGenerators at initial configuration #109

Closed xela-95 closed 4 months ago

xela-95 commented 4 months ago

Closes #108

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 55.19%. Comparing base (98f78ae) to head (4617d97). Report is 1 commits behind head on main.

:exclamation: Current head 4617d97 differs from pull request most recent head c6a3e00. Consider uploading reports for the commit c6a3e00 to get more accurate results

Files Patch % Lines
plugins/controlboard/src/ControlBoard.cpp 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #109 +/- ## ========================================== + Coverage 54.65% 55.19% +0.53% ========================================== Files 26 27 +1 Lines 2684 2694 +10 ========================================== + Hits 1467 1487 +20 + Misses 1217 1207 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

traversaro commented 4 months ago

Do you have any idea why codecov continues to spam messages?

xela-95 commented 4 months ago

Do you have any idea why codecov continues to spam messages?

unfortunately my updates to the CI yaml were not effective... I think I need to create a separate codecov.yaml file to customize its behavior: https://docs.codecov.com/docs/codecov-yaml

xela-95 commented 4 months ago

Anyhow it is possible to reproduce the exception I got in https://github.com/robotology/gz-sim-yarp-plugins/issues/103#issuecomment-1978894636 by launching the single pendulum tutorial and by commenting out the <initialConfiguration> block: https://github.com/robotology/gz-sim-yarp-plugins/blob/1e86adb9247b159900c4eae312222950fa0f70f1/tutorial/single_pendulum/model.sdf#L99

Also here I verified that I had an empty vector as the result of calling: https://github.com/robotology/gz-sim-yarp-plugins/blob/98f78ae5fff2fbcc8f5f240b3cb87475cded5451/plugins/controlboard/src/ControlBoard.cpp#L874

xela-95 commented 4 months ago

We're getting (again) a failure in the macos tests, in particular on the new test implemented: https://github.com/robotology/gz-sim-yarp-plugins/actions/runs/8160658434/job/22307711533?pr=109#step:12:50

 libc++abi: terminating with uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument

An interesting reference on SO: https://stackoverflow.com/questions/66773247/libcabi-dylib-terminating-with-uncaught-exception-of-type-std-1system-er

xela-95 commented 4 months ago

We're getting (again) a failure in the macos tests, in particular on the new test implemented: https://github.com/robotology/gz-sim-yarp-plugins/actions/runs/8160658434/job/22307711533?pr=109#step:12:50

 libc++abi: terminating with uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument

An interesting reference on SO: https://stackoverflow.com/questions/66773247/libcabi-dylib-terminating-with-uncaught-exception-of-type-std-1system-er

Also this could be related to the bug #102, since different platforms I'mplement locking mechanisms in different ways, this problem maybe shows up only on macOs...

xela-95 commented 4 months ago

Since this macOS issue is not related to the current development and is already documented in #90, I will exclude the new test from it for the time being.

xela-95 commented 4 months ago

Test passed! Merging 🚀