search

robotology / gz-sim-yarp-plugins

YARP plugins for Modern Gazebo (gz-sim).
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

Develop Gazebo Garden FT sensor YARP plugin #4

Closed traversaro closed 1 year ago

traversaro commented 1 year ago

Useful resources:

lucapa17 commented 1 year ago

If possible, could you help us dividing this issue into different steps?

traversaro commented 1 year ago

If possible, could you help us dividing this issue into different steps?

Ok! Possible steps that come to my mind are (feel free to open individual issues):

We can also quickly align in person to be more clear. Not sure if @randaz81 is available in the next days, but I will contact him and check if he can.

GiacomoBisio commented 1 year ago

It's ok for us! Thank you!

lucapa17 commented 1 year ago

Done!

Done!

  • Modify the plugin to read FT sensors measures and print it to the command line

We added two issues:

GiacomoBisio commented 1 year ago

We added a new issue:

lucapa17 commented 1 year ago

We added a new issue:

lucapa17 commented 1 year ago

@traversaro At this point in which way do you suggest to proceed? We think that it could be the moment to reorganize the disposition of our files. Indeed we have the last version of the plugin in robotinterface/step5 because we followed the steps that you suggested to implement the plugin using the Robot Interface.

traversaro commented 1 year ago

@traversaro At this point in which way do you suggest to proceed?

Sorry, I forgot to look into https://github.com/robotology/study-gazebo-garden-yarp-plugins/issues/11 and then I forgot to tell you how to go forward, my bad. : (

I think we can proceed as in the following. As you suggested, probably it make sense now to cleanup a bit the repo, by having a folder for each plugin, and removing the step folders that came from the implementation of the yarprobotinterface taht are not useful anymore. If you want to do that, it may be worth to this in the form of a pull request, so that then we can provide feedback in form of a pull request review (see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews), that permits to us to provide more detailed feedback on all the code. We can open a dedicated issue for that.

Another alternative that you can start looking into, that is kind of indipendent from https://github.com/robotology/study-gazebo-garden-yarp-plugins/issues/11, is that you can start looking into implementing an imu plugin, i.e. a device that implements the yarp::dev::IOrientationSensors, yarp::dev::IThreeAxisGyroscopes and yarp::dev::IThreeAxisLinearAccelerometers.

traversaro commented 1 year ago

Anyhow, we can also quickly align on Teams to discuss about this in person, when are you available in this week?

lucapa17 commented 1 year ago

Anyhow, we can also quickly align on Teams to discuss about this in person, when are you available in this week?

Starting from this Thursday we are always available

traversaro commented 1 year ago

Anyhow, we can also quickly align on Teams to discuss about this in person, when are you available in this week?

Starting from this Thursday we are always available

Ok, I sent an invite for Thursday 9:30 - 10:30 !