robotology / gz-sim-yarp-plugins

YARP plugins for Modern Gazebo (gz-sim).
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Adapt gz-sim-yarp-plugins to work with gz-sim8 #58

Closed xela-95 closed 9 months ago

xela-95 commented 10 months ago

We want make the plugins of this repo to work with the latest stable release of Gazebo, i.e. Gazebo Sim 8: Harmonic

TODO

xela-95 commented 9 months ago

I created a fresh new mamba environment with the following command:

mamba create -c conda-forge -n gz8 libgz-sim8 yarp cmake ninja pkg-config cmake compilers

hen I activate this environment I get the following warning:

WARNING: No ICDs were found. Either,
- Install a conda package providing a OpenCL implementation (pocl, oclgrind, intel-compute-runtime, beignet) or 
- Make your system-wide implementation visible by installing ocl-icd-system conda package. 

@traversaro are you familiar with this?

xela-95 commented 9 months ago

Unrelated to the previous message:

For my development setup I use additional packages, my mamba environment is in fact created as:

mamba create -c conda-forge -n gz8 libgz-sim8 yarp cmake ninja pkg-config cmake compilers clang clang-tools clang-format include-what-you-use 

Should I update the README with all those packages, or create separate environments.yaml for development and usage of the package?

traversaro commented 9 months ago

As gz-sim7 is part of Gazebo Garden (see https://gazebosim.org/docs/garden/install) and Gazebo Garden is a short-term support release of Gazebo (support will stop in November 2024, see https://gazebosim.org/docs/harmonic/releases), I think it is ok to just support gz-sim8 . In the future we may want to to support multiple version of gz-sim at the same time, but I see little value in trying to remain compatible with gz-sim7 at this stage.

traversaro commented 9 months ago

Should I update the README with all those packages, or create separate environments.yaml for development and usage of the package?

Yes, I would separate the dependencies strictly required for the package usage, and the development dependencies. Anyhow, eventually we will add gz-sim-yarp-plugins will be added to conda-forge and to the robotology-superbuild, so the two main way of usage document in the README will be those one (see for example the idyntree README: https://github.com/robotology/idyntree?tab=readme-ov-file#installation) so eventually this will not be a big problem.

traversaro commented 9 months ago

hen I activate this environment I get the following warning:

WARNING: No ICDs were found. Either,
- Install a conda package providing a OpenCL implementation (pocl, oclgrind, intel-compute-runtime, beignet) or 
- Make your system-wide implementation visible by installing ocl-icd-system conda package. 

@traversaro are you familiar with this?

Yes, see https://github.com/conda-forge/ocl-icd-feedstock/issues/29 . TL;DR: you can ignore this for now, but this could be problematic in non-bash shells.