search

robotology / gz-sim-yarp-plugins

YARP plugins for Modern Gazebo (gz-sim).
BSD 3-Clause "New" or "Revised" License
8 stars 0 forks source link

Rename robotinterface singleton with clear name #69

Closed traversaro closed 3 months ago

traversaro commented 5 months ago

Lines like:

Handler::getHandler()->setDevice(m_deviceScopedName, &m_baseStateDriver)

are quite confusing, as they do not refer anywhere the robotinterface plugin. We should rename this to make this lines clear.

xela-95 commented 3 months ago

@traversaro what do you think of

RobotInterfaceSingleton::getHandler()->setDevice(m_deviceScopedName, &m_baseStateDriver)

?

traversaro commented 3 months ago

Thanks! Sorry I was in a meeting, I commented directly in the PR.