search

robotology / human-dynamics-estimation

Software repository for estimating human dynamics
BSD 3-Clause "New" or "Revised" License
83 stars 28 forks source link

Update ros launch files xacro usage for ros noetic #200

Closed yeshasvitirupachuri closed 3 years ago

yeshasvitirupachuri commented 4 years ago

Ubuntu 20.04 does not support ROS Melodic and it is recommended to use ROS Noetic. When trying to launch rviz visualization using the launch files, the following error was thrown:

Screenshot from 2020-06-23 16-01-57

On double checking with the urdf_tutorial display.launch file, I notice the usage of xacro has been updated in https://github.com/ros/urdf_tutorial/commit/dadba7524ba0d20ecd6d23095f49843c3f8e8d1b#diff-7f8c819cc88e03640153972121b4f8cd. So, I changed the usage of xacro in the HDE launch files too and rviz runs correctly.

We need to check if updating the xacro usage on Ubuntu 18.04 will not cause any trouble and update the launch files accordingly.

CC @lrapetti @kouroshD @claudia-lat

lrapetti commented 3 years ago

Given that this change should be there since ROS Jade http://wiki.ros.org/xacro#Processing_Order (2015 distribution), I think we should be able to safely update it.

I will open a PR for this change.

claudia-lat commented 3 years ago

We can close the issue.