search

robotology / human-dynamics-estimation

Software repository for estimating human dynamics
BSD 3-Clause "New" or "Revised" License
81 stars 28 forks source link

Release v2.2.0 #231

Closed lrapetti closed 3 years ago

lrapetti commented 3 years ago

The last release was done almost one year ago with the v2.1.0 tag, and since then new features have been released. I think it's time to release it.

Indeed we should proceed:

I think also we might align with the rest of robotology removing the devel branch, keeping the released tags as stable code pointers, and using master as development branch.

cc @Yeshasvitvs @traversaro @diegoferigo

yeshasvitirupachuri commented 3 years ago

@lrapetti I agree with it.

I hoped to had test/devel-rebase tested before making a new release, as this would have enabled to pull in the changes from https://github.com/robotology/human-dynamics-estimation/pull/181 to upstream.

NOTE: PR link above update from original posting

However, at this point it is cleaner have a release from merging devel to master.

I think also we might align with the rest of robotology removing the devel branch, keeping the released tags as stable code pointers, and using master as development branch.

Good call. This will make things aligned with how wearable is maintained too.

yeshasvitirupachuri commented 3 years ago

Before the release, may be checking the config yarp manager files for iCub visualization through https://github.com/robotology/human-dynamics-estimation/pull/230 can be useful to have tested and committed to upstream for the next iteration of tests for retargeting.

@S-Dafarra

yeshasvitirupachuri commented 3 years ago

@lrapetti merged devel into master branch https://github.com/robotology/human-dynamics-estimation/commit/d6fdd7a8627ef71dc49225d716e11aff7ab043bc

lrapetti commented 3 years ago

I hoped to had test/devel-rebase tested before making a new release, as this would have enabled to pull in the changes from #181 to upstream.

The main problem there is that it depends on a branch of iDynTree (https://github.com/robotology/idyntree/pull/783), so for the time being that branch can not be merged to a stable release.

yeshasvitirupachuri commented 3 years ago

Windows CI failed on push flow after merge at https://github.com/robotology/human-dynamics-estimation/runs/1790878536#step:9:10886, looking for IRRLICHT_INCLUDE_DIR

lrapetti commented 3 years ago

Windows CI failed on push flow after merge at https://github.com/robotology/human-dynamics-estimation/runs/1790878536#step:9:10886, looking for IRRLICHT_INCLUDE_DIR

The failure has now been fixed (https://github.com/robotology/human-dynamics-estimation/pull/232), @Yeshasvitvs we can create the new release, what do you think?

yeshasvitirupachuri commented 3 years ago

@lrapetti following https://github.com/robotology/human-dynamics-estimation/pull/235 https://github.com/robotology/human-dynamics-estimation/pull/234 https://github.com/robotology/human-dynamics-estimation/pull/233 do you foresee any further small changes that are to be done before a release ?

lrapetti commented 3 years ago

do you foresee any further small changes that are to be done before a release ?

No, I am not planning any change, for me we can proceed with the release.

yeshasvitirupachuri commented 3 years ago

@lrapetti and I did the new release https://github.com/robotology/human-dynamics-estimation/releases/tag/v2.2.0

yeshasvitirupachuri commented 3 years ago

Expecting an automatic update of robotology-superbuild, similar to https://github.com/robotology/robotology-superbuild/pull/607

yeshasvitirupachuri commented 3 years ago

I think also we might align with the rest of robotology removing the devel branch, keeping the released tags as stable code pointers, and using master as development branch.

@lrapetti We can open a separate issue for this task, and also align https://github.com/robotology/wearables with release tag branches

traversaro commented 3 years ago

I think also we might align with the rest of robotology removing the devel branch, keeping the released tags as stable code pointers, and using master as development branch.

Just to clarify, not using devel is a strategy that make sense and I think it make sense to use for you, but it is not used by all robotology projects. At the moment is used by YARP and YCM, but not (for example) by icub-main . At the moment the master branch of this repo is still the default branch used by anyone that downloads the robotology-superbuild and compiles it with the default settings with ROBOTOLOGY_ENABLE_HUMAN_DYNAMICS , that is ROBOTOLOGY_PROJECT_TAGS set to Stable. In the future we may change this default to use the latest-releases.yaml file introduced in https://github.com/robotology/robotology-superbuild/pull/596 , but probably we will need to discuss about it before doing so.

lrapetti commented 3 years ago

Cross linking the comment from @traversaro https://github.com/robotology/human-dynamics-estimation/pull/233#issuecomment-772591190.

In brief this release is currently not aligned with the stable branch of iDynTree if Irrlicht is enabled. For the same reason, the CI is currenty pointing to the iDynTree devel branch (https://github.com/robotology/human-dynamics-estimation/blob/master/.github/workflows/ci.yml#L19), this will change as iDynTree will be relased (https://github.com/robotology/idyntree/issues/804).

traversaro commented 3 years ago

Expecting an automatic update of robotology-superbuild, similar to robotology/robotology-superbuild#607

FYI that scripts runs every sunday night (see https://github.com/robotology/robotology-superbuild/blob/8f415ed824730de37d886806e1db58d88117a6be/.github/workflows/update-latest-releases.yml#L9), so if you want to bump the release before manually feel free to do so.