search

robotology / human-dynamics-estimation

Software repository for estimating human dynamics
BSD 3-Clause "New" or "Revised" License
81 stars 28 forks source link

Human State Provider: fix the bug related to the zero output qp solver #272

Closed kouroshD closed 2 years ago

kouroshD commented 2 years ago

With this PR, I am fixing the problem related to the QP that returns zero values as the solution. reference issue: https://github.com/robotology/human-dynamics-estimation/issues/167

The format of the files updated are set to clang format.

kouroshD commented 2 years ago

Probably, we can add the default solver to QP. what do you say @lrapetti ?!

kouroshD commented 2 years ago

I have separated the commit for the clang format updates of the files and the real commit for the bug fix. Ready to be reviewed @lrapetti

lrapetti commented 2 years ago

Thanks, @kouroshD! I just realized that it would be better not to merge the clang form at this stage since it would increase a lot the complexity for rebasing the child banch on which I have already started working (https://github.com/robotology/human-dynamics-estimation/tree/add-different-target-types).

If for you is ok, I would remove the clang commit and merge this fix.

kouroshD commented 2 years ago

@lrapetti Feel free to proceed as you suggested.

lrapetti commented 2 years ago

@lrapetti Feel free to proceed as you suggested.

Done. I will merge it in the main PR (https://github.com/robotology/human-dynamics-estimation/pull/265)