robotology / human-dynamics-estimation

Software repository for estimating human dynamics
BSD 3-Clause "New" or "Revised" License
81 stars 28 forks source link

Add different target and sensors type in HumanStateProvider #274

Closed lrapetti closed 2 years ago

lrapetti commented 2 years ago

This PR implement the possibility of using different type of wearable sensors and associate them with different sensors type (https://github.com/robotology/human-dynamics-estimation/issues/273).

Currently the following sensor/targets type have been implemented:

Before merging:

After merging:

lrapetti commented 2 years ago

With https://github.com/robotology/human-dynamics-estimation/pull/274/commits/2d9da1112a027ae522935780bb74f4012054784e I am adding to this PR the possibility to pass from configuration file both a left and a right rotation transform to apply to the measurements. Those can be defined using the following group parameters name:

lrapetti commented 2 years ago
  • [x] Fix and test the calibration methods

This point have been addressed. Note that, however, in https://github.com/robotology/human-dynamics-estimation/pull/274/commits/c1b03635943422e5f23def005a00b11fe7262fa3 I have removed two calibration methods that currently were not used:

lrapetti commented 2 years ago
  • [ ] Fix Pairwised IK

Since we are now enabling the possibility of having multiple targets for the same links and we are adding also position sensors (that can not be taken into account by using reduced models only), I think we can think of deprecating the pairwise IK methods since it is not straightforward to align it with the new changes.

What do you think @S-Dafarra @kouroshD?

A similar problem exists for the Global IK, we can not define multiple targets for the same link, but in this case I would try to maintain it for the case in which multiple targets are not defined for the same link.

S-Dafarra commented 2 years ago
  • [ ] Fix Pairwised IK

Since we are now enabling the possibility of having multiple targets for the same links and we are adding also position sensors (that can not be taken into account by using reduced models only), I think we can think of deprecating the pairwise IK methods since it is not straightforward to align it with the new changes.

What do you think @S-Dafarra @kouroshD?

A similar problem exists for the Global IK, we can not define multiple targets for the same link, but in this case I would try to maintain it for the case in which multiple targets are not defined for the same link.

I think that's ok to deprecate it, also because until now we did not find a case where it was working better

lrapetti commented 2 years ago

Closing this PR for the time being. To be reopened once all the required changes are completed.