search

robotology / human-dynamics-estimation

Software repository for estimating human dynamics
BSD 3-Clause "New" or "Revised" License
81 stars 28 forks source link

Add parameter for setting all the position scaling factors at once #289

Closed lrapetti closed 2 years ago

lrapetti commented 2 years ago

This PR adds the possibility to use a single parameter (x_scale_factor_all,y_scale_factor_all,z_scale_factor_all) for the position scale factors for all the targets.

In this way, until https://github.com/robotology/yarp/issues/2812 is not fixed, the scale factors can be passed via command line (as long as we want to set them to the same value for all the targets). I have also added the extern-name option in the RobotStateProvider_iCub2_5_openxr_ifeel.xml configuration so that we can set then as:

yarprobotinterface --config RobotStateProvider_iCub2_5_openxr_ifeel.xml --xy_scale $SCALE_FOR_XY --z_scale $SCALE_FOR_Z
lrapetti commented 2 years ago

@S-Dafarra after merging this, we can test it with the full system working and add it to the yarpmanager configuration

lrapetti commented 2 years ago

@S-Dafarra after merging this, we can test it with the full system working and add it to the yarpmanager configuration

I have already opened the PR for the yarpmanager application at https://github.com/robotology/walking-teleoperation/pull/93/files

lrapetti commented 2 years ago

Concerning the spacing, it seems the clang-format didn't work out. Anyway I'll proceed merging since we might not even want to port this change as it is in main development branch in the future