Closed lrapetti closed 2 years ago
@RiccardoGrieco note that something similar, I took inspiration from, was implemented in human-dynamics-estimation/feature/SOT-Berdy-HDE/devices/HumanWrenchProvider/HumanWrenchProvider.cpp
Sorry for the delay @lrapetti. I will do the review soon.
I would also add an example of how to use the feature in the main configuration file https://github.com/robotology/human-dynamics-estimation/blob/add-dummy-wrench-source/conf/xml/Human.xml (even if commented out).
I would also add an example of how to use the feature in the main configuration file https://github.com/robotology/human-dynamics-estimation/blob/add-dummy-wrench-source/conf/xml/Human.xml (even if commented out).
@RiccardoGrieco let me know if you have other comments
I would also add an example of how to use the feature in the main configuration file https://github.com/robotology/human-dynamics-estimation/blob/add-dummy-wrench-source/conf/xml/Human.xml (even if commented out).
Done in d544e83
Perfect! 👍🏻
@RiccardoGrieco let me know if you have other comments
No more comments from my side to add, but there are still the pending ones to be addressed.
@RiccardoGrieco let me know if you have other comments
No more comments from my side to add, but there are still the pending ones to be addressed.
mm I cannot see them
With https://github.com/robotology/human-dynamics-estimation/pull/299/commits/69d15cb99801cfbaf13b7d9561fd4b337e44581a I have unified the wrench transformer objects that at this stage where all applying the same transform and the main difference was the fact that they were storing some additional transforms (either unused, or not directly related to wrench transformation).
I have also improved some parameters for the robot case (even if at this stage is unused)
@RiccardoGrieco can we proceed to merge or do you have other comments?
Thanks @RiccardoGrieco
This PR adds the possibility to define a wrench source of type
dummy
in theHumanWrenchProvider
device that can be set to an initial wrench value (usingvalue
parameter), e.g.and that can be also be set from rpc port, e.g.
(wrenches are in mixed representation, see traversaro-phd-thesis.pdf for further info on that)