search

robotology / human-dynamics-estimation

Software repository for estimating human dynamics
BSD 3-Clause "New" or "Revised" License
80 stars 28 forks source link

Make dependency on robometry optional and add it in the documentation #323

Closed lrapetti closed 1 year ago

lrapetti commented 1 year ago

In https://github.com/robotology/human-dynamics-estimation/pull/298 we forgot to update the documentation with the robometry dependency.

lrapetti commented 1 year ago

Note that the library is still marked as Under Development. We might think of making this dependency optional

RiccardoGrieco commented 1 year ago

Note that the library is still marked as Under Development. We might think of making this dependency optional

If we want to make it optional we should address it also in the device CMakeLists.txt

lrapetti commented 1 year ago

Note that the library is still marked as Under Development. We might think of making this dependency optional

If we want to make it optional we should address it also in the device CMakeLists.txt

Yess, it has been addressed in https://github.com/robotology/human-dynamics-estimation/pull/323/commits/165183da985950e8524b091814c96ba8825ce4cd. I have changed the title of the PR to reflect this change

lrapetti commented 1 year ago

@RiccardoGrieco do you have any further comment or can we merge it?