robotology / human-dynamics-estimation

Software repository for estimating human dynamics
BSD 3-Clause "New" or "Revised" License
80 stars 28 forks source link

Update ycm version in CI #328

Closed lrapetti closed 1 year ago

lrapetti commented 1 year ago

The CI seems to be failing due to ycm version (see https://github.com/robotology/human-dynamics-estimation/actions/runs/3598326088)

lrapetti commented 1 year ago

It seems that icub-main requires also to update also the version of yarp. I am a bit confused since the icub-main tag we are using (1.21.0) does not seems to require those versions (see https://github.com/robotology/icub-main/blob/v1.21.0/CMakeLists.txt).

lrapetti commented 1 year ago

It seems that icub-main requires also to update also the version of yarp. I am a bit confused since the icub-main tag we are using (1.21.0) does not seems to require those versions (see https://github.com/robotology/icub-main/blob/v1.21.0/CMakeLists.txt).

It seems that it is using the icub-main in master:

...
Cloning into 'icub-main'...
Your branch is up to date with 'origin/master'.
-- The C compiler identification is GNU 9.4.0
-- The CXX compiler identification is GNU 9.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found YCM: /home/runner/work/human-dynamics-estimation/human-dynamics-estimation/install/deps/share/cmake/YCM (found version "0.14.2")
CMake Error at CMakeLists.txt:25 (find_package):
  Could not find a configuration file for package "YARP" that is compatible
  with requested version "3.7.2".
-- Configuring incomplete, errors occurred!
See also "/home/runner/work/human-dynamics-estimation/human-dynamics-estimation/icub-main/build/CMakeFiles/CMakeOutput.log".

  The following configuration files were considered but not accepted:

    /home/runner/work/human-dynamics-estimation/human-dynamics-estimation/install/deps/lib/cmake/YARP/YARPConfig.cmake, version: 3.7.1
lrapetti commented 1 year ago

I found out the issue, there was a mistake in the name of the variable used in the CI, so we have always been using the master branch of icub-main. Fixed in https://github.com/robotology/human-dynamics-estimation/pull/328/commits/2d6311ad97497d6d1d29d9dac0febe3a34a5e5b9