search

robotology / human-dynamics-estimation

Software repository for estimating human dynamics
BSD 3-Clause "New" or "Revised" License
78 stars 28 forks source link

Update nws/nwc naming convention #367

Closed davidegorbani closed 8 months ago

davidegorbani commented 9 months ago

This PR closes #359; with this PR the naming convention of the Wrapper and the Remapper is updated to the nws/nwc now used for the servers and clients in YARP.

lrapetti commented 9 months ago

Great @davidegorbani, I will go trough this PR soon. CI on Windows is failing, but the issue seems to be unrelated to your PR.

Moreover, before merging I would like to fix https://github.com/robotology/human-dynamics-estimation/issues/366 and do a Release, since this PR will break compatibility with old configurations.

davidegorbani commented 9 months ago

I rebased the branch on master, I tested on my laptop the HumanStateVisualizer and it is working fine.

lrapetti commented 9 months ago

I rebased the branch on master, I tested on my laptop the HumanStateVisualizer and it is working fine.

Great, however there seems to be a conflict in the files and the commit history seems not to be clean. We can have a look at this together tomorrow!

davidegorbani commented 8 months ago
  • can you update the CHANGELOG.md with the relevant modifications?

Yes, sure.

  • think we can also change the name of the folders in which those files are currently stored (so removing the wrappers and remappers folder).

I was considering changing those names, is it fine servers and clients?

davidegorbani commented 8 months ago

Yes, sure!

davidegorbani commented 8 months ago

I changed also the name of the namespaces.