robotology / human-gazebo

URDF models of humans created to perform human robot interaction experiments.
GNU Lesser General Public License v2.1
136 stars 40 forks source link

Are files in the `legacy` directory mantained? #23

Open traversaro opened 3 years ago

traversaro commented 3 years ago

I noticed that those files contained a [VELOCITY_CONTROL] group that will stop working in gazebo-yarp-plugins 4 once the velocityControlImplementationType parameter, introduced in gazebo-yarp-plugins v3.5.1 https://github.com/robotology/gazebo-yarp-plugins/blob/master/CHANGELOG.md#351---2020-10-05 , will be made compulsory instead of automatically use the default value direct_velocity_pid. If those files are not mantained, why we don't just tag a release that contains them, and then remove them from the master branch of the repo?

traversaro commented 3 years ago

Related to https://github.com/robotology/gazebo-yarp-plugins/issues/577 .

lrapetti commented 3 years ago

Files in legacy are no longer maintained, I think we can proceed to remove them as you were mentionaing.

lrapetti commented 2 years ago

@MarcoCaianiello is currently working on those files. Indeed rather then deprecating them, we could revive it by pushing the updated, and working, configuration.