robotology / icub-firmware-models

Models underlying the iCub Firmware
https://robotology.github.io/icub-firmware-models/
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

AMCBLDC – Make `Vmax` + other useful params configurable via CAN #8

Open pattacini opened 1 year ago

pattacini commented 1 year ago

As of now, Vcc and Vmax are statically defined in the model. This prevents us from adapting those parameters to the setups/robots w/o re-generating the code.

It'd be thus great to have the possibility to tune the voltage values on the fly via CAN, for example to adapt for cable or battery voltage supply. We haven't done that yet as the current CAN protocol doesn't foresee this option.

EDIT

We may consider at this stage including other motor-related useful parameters to configure via CAN; see also #14.

In total:

pattacini commented 1 year ago

Actually, it turns out that Vcc can be read by the board using ADC. This would enable us to automatically adapt wrt. a constantly changing battery voltage. Opening a dedicated issue for this.

pattacini commented 1 year ago

cc @marcoaccame @sgiraz @fgarini @valegagge

valegagge commented 1 year ago

Hi guys, I just want to add a note regarding this new feature.

In AMC-BLDC, @ale-git had already implemented two motor parameters:

It would be great if these parameters were included in the new CAN protocol. We are available to discuss together where to insert these parameters.

I suggest only designing the new protocol taking in mind these parameters also, but not making them work: we can do it in a different activity.

pattacini commented 1 year ago

Agreed @valegagge 👍🏻 Added them up to the OP.