robotology / icub-firmware

iCub Firmware
Other
11 stars 29 forks source link

Fix on all Diagnostic error #471

Closed MSECode closed 6 months ago

MSECode commented 7 months ago

Add mspassed to State::justLOST Fix errors with service category passed, time from last contact and can mapping in canmonitor errors Fix Config constexpr, Initialize boards2report as boards2touch periodofreport params not updated to prv var boards2report now initialized to zero as for boards2touch instead of to be re-initialized at each CANmonitor.tick() call initially set as _config.target and cleaned at CANmonitor.stop() Now the diagnostic maps are filled correctly. Clean boads2report when inside the check and reset periodofreport to 10 sec.

Report all fixes:

valegagge commented 7 months ago

Hi @MSECode, this PR is fine for me. I'm going to wait for the tests before reviewing.

MSECode commented 6 months ago

need to update new versions of the fw to have the build aligned

MSECode commented 6 months ago

Need to update the new fw versions for the boards so that they are aligned with the build