search

robotology / icub-models-generator

Resources and programs to generated models (URDF, SDF) of the iCub robot
14 stars 23 forks source link

Fix ordering of the joint for the torso controlboard of iCubGenova 2.* #237

Closed traversaro closed 1 year ago

traversaro commented 1 year ago

Fix https://github.com/robotology/icub-models/issues/191 .

traversaro commented 1 year ago

Sorry, I merged but I have just realized that probably we should also change the jntPosMax and jntPosMin parameters.

Nicogene commented 1 year ago

Sorry, I merged but I have just realized that probably we should also change the jntPosMax and jntPosMin parameters.

Looking here it seems that those have been left unchanged, just swapped the names

traversaro commented 1 year ago

Sorry, I merged but I have just realized that probably we should also change the jntPosMax and jntPosMin parameters.

Looking here it seems that those have been left unchanged, just swapped the names

Good catch. The limits seems also to be consistent w.r.t. https://github.com/robotology/icub-models-generator/blob/master/simmechanics/data/icub2_5/ICUB_2-5_BB_joint_parameters.csv.in#L2, so nothing else is necessary.