search

robotology / icub-models-generator

Resources and programs to generated models (URDF, SDF) of the iCub robot
14 stars 23 forks source link

Update torso PID gains of icub2.5 #241

Closed pattacini closed 1 year ago

pattacini commented 1 year ago

Tuned-up PID gains for torso.

These gains are those that makes icub-gazebo-grasping-sandbox work properly. See https://github.com/robotology/icub-gazebo-grasping-sandbox/issues/45#issuecomment-1607312102.

traversaro commented 1 year ago

I guess we can just adopt this gains, if anyone is experiencing regression from this please open an issue, thanks!

pattacini commented 12 months ago

Hi @traversaro

For some reason, icub-models didn't get updated in this respect. I can still see the old PIDs at https://github.com/robotology/icub-models/blob/master/iCub/conf/gazebo_icub_torso.ini.

pattacini commented 12 months ago

Checking this out w/ @Nicogene, it turned out that devel didn't get merged into master before the release.

See https://github.com/robotology/icub-models/network.

Perhaps, we could merge it and retag the release?

traversaro commented 12 months ago

Perhaps, we could merge it and retag the release?

Done: https://github.com/robotology/icub-models/releases/tag/v2.2.1 .

pattacini commented 12 months ago

Thanks!