search

robotology / icub-models

Official URDF and SDF models of the iCub humanoid robot.
Creative Commons Attribution Share Alike 4.0 International
33 stars 34 forks source link

`velocityControlImplementationType` missing parameter for iCubGazeboV3 #106

Closed GiulioRomualdi closed 3 years ago

GiulioRomualdi commented 3 years ago

This parameter is required after the gazebo yarp plugin v4.0.0 release

mebbaid commented 3 years ago

any updates on this issue ?

GiulioRomualdi commented 3 years ago

This should fix by https://github.com/robotology/icub-models-generator/pull/212

Could you try with the devel branch?

mebbaid commented 3 years ago

@traversaro this maybe the issue that the Jonathan from Australia was having (he mentioned this during the ergocub update meeting). Couldn't tag him because i didn't find him on this site.

GiulioRomualdi commented 3 years ago

Fixed by 6239efecaf2d19368d14ad5a322ec0afc767c8a8

lrapetti commented 3 years ago

@traversaro this maybe the issue that the Jonathan from Australia was having (he mentioned this during the ergocub update meeting). Couldn't tag him because i didn't find him on this site.

@Woolfrey

traversaro commented 3 years ago

Thanks a lot @mebbaid, I think indeed that it is! https://github.com/robotology/icub-models/commit/6239efecaf2d19368d14ad5a322ec0afc767c8a8 (and the related PR https://github.com/robotology/icub-models-generator/pull/212) fixed it in devel, but probably @Woolfrey downloaded either master or released version of icub-models. Let's release a new version of icub-models so users can get a working iCub3 models without a lot of hassle.

traversaro commented 3 years ago

Hopefully we can do a 1.22 release (see https://github.com/robotology/icub-models/pull/109) to avoid confusion in all users.

traversaro commented 3 years ago

Hopefully we can do a 1.22 release (see #109) to avoid confusion in all users.

Done: https://github.com/robotology/icub-models/releases/tag/v1.22.0 .

traversaro commented 3 years ago

Hopefully we can do a 1.22 release (see #109) to avoid confusion in all users.

Done: https://github.com/robotology/icub-models/releases/tag/v1.22.0 .

I also updated the LatestReleases file in the robotology-superbuild: https://github.com/robotology/robotology-superbuild/pull/920 . So the next conda package generation will get the updated icub-models, let me know if there is anything else that we could do to make sure that this issue is fixed without the need for the user to manually switch branches or do stuff like that. @mebbaid @Woolfrey

mebbaid commented 3 years ago

@traversaro it seems that this fixes the issue and the iCubGazeboV3 starts correctly.

Woolfrey commented 3 years ago

I saw this; thanks!

Github notifications are being sent to my gmail instead of my iit email.