Closed GiulioRomualdi closed 2 years ago
cc @traversaro @Nicogene
Hi @traversaro, I applied the suggestions you proposed. Before merging the PR I would like to highlight:
master
I opened the PR on devel. I don't know if it is fine or I should change the base branch to
master
Devel is fine.
I should write something in the readme
Yes, that would great otherwise people will never know of the feature! The README probably would need a revamp in general (see https://github.com/robotology/icub-models/issues/90), but I think that for this feature I think it is ok to just add two sections after https://github.com/robotology/icub-models#use-the-models-with-gazebo, something like:
@traversaro I updated the README in https://github.com/robotology/icub-models/pull/130/commits/6da40e2f84aee8c7888fa133854ff40ae0388ba1
For me it is ok! Can you add a note in the CHANGELOG.md ? Thanks!
Thanks!
With this PR I want to propose a solution for the https://github.com/robotology/icub-models/issues/91. In 3c869f1c0d02bfa99d5a49b5c02a6e4cbb57ae25, I implemented a C++ library that will allow us to easily access the location of a model installed in by
icub-models
repo. The location of the files is automatically generated by acmake
machine that is in charge to set thepath
accordingly to the installation folder.I also implemented the python bindings (with pybind11) 8d7efc78a4e9f9048546481c4a2fe2a1339d3ef6. In theory, it would be possible to use swig to support more language. However, since I've never used it I've preferred to start with something simpler.
This is an python script where I used the module. I replicated the API suggested by @traversaro in https://github.com/robotology/icub-models/issues/91#issue-912245566